Tone Melody Example

i've been working tone melody example built ide teach students how play tunes, i'm confused why hard codes number of notes loop.
would following not better for loop, or missing obvious?:

code: [select]


for (int thisnote = 0; thisnote < sizeof(melody)/sizeof(int); thisnote++) {

this way, code automatically adapt size of melody array (by calculating how many integers in it), , beginner need able use change notes , durations in 2 arrays.
i'm not sure if best place post this, i'm curious see why might not desirable, or if better, starting out making arduino play music!

i'd suggest improvement - put note , duration in same array 1 can enter note , play length together. easier enter/edit song way , keep them in sync. put /2 in sizeof somewhere, increment loop two, array[thisnote] tone, , array[thisnote+1] duration.
give try, see how works out.

Arduino Forum > Using Arduino > Project Guidance > Tone Melody Example

arduino