[FIXED] - Contact component - no "label" for mobile phone in contact display - Joomla! Forum - community, help and support

i'm using latest nightly build - changelog shows 1 change on oct. 4 2007.

the contact component has place add mobile phone number, there no text or icon mobile phone displayed.

i've checked language file , found "mobile phone number" there.

i checked components/com_contact/views/contact/view.html.php has no "marker" line mobile:

code: select all

case 1 :
      // text
      $contact->params->set('marker_address',    jtext::_('address').": ");
      $contact->params->set('marker_email',       jtext::_('email').": ");
      $contact->params->set('marker_telephone',    jtext::_('telephone').": ");
      $contact->params->set('marker_fax',       jtext::_('fax').": ");
      $contact->params->set('marker_misc',       jtext::_('information').": ");
      $contact->params->set('column_width',       '100');
      break;


and in components/com_contact/views/contact/tmpl/default_address.php there no line display marker:

code: select all

<?php if ( $this->contact->mobile && $this->contact->params->get( 'show_mobile' ) ) :?>
<tr>
   <td width="<?php echo $this->contact->params->get( 'column_width' ); ?>" >
   </td>
   <td>
      <?php echo nl2br($this->contact->mobile); ?>
   </td>
</tr>
<?php endif; ?>

to test if assumptions correct, modified both of files on site see happen (adding marker text, in case, since there no image mobile phone)... , delight, worked!!  :d

so, changed case1 in view.html.php to:

code: select all

case 1 :
      // text
      $contact->params->set('marker_address',    jtext::_('address').": ");
      $contact->params->set('marker_email',       jtext::_('email').": ");
      $contact->params->set('marker_telephone',    jtext::_('telephone').": ");
      $contact->params->set('marker_fax',       jtext::_('fax').": ");
      $contact->params->set('marker_mobile',      jtext::_('mobile').": ");
      $contact->params->set('marker_misc',       jtext::_('information').": ");
      $contact->params->set('column_width',       '100');
      break;


and mobile display in default_address.php to:

code: select all

<?php if ( $this->contact->mobile && $this->contact->params->get( 'show_mobile' ) ) :?>
<tr>
   <td width="<?php echo $this->contact->params->get( 'column_width' ); ?>" >
   <?php echo $this->contact->params->get( 'marker_mobile' ); ?>
   </td>
   <td>
      <?php echo nl2br($this->contact->mobile); ?>
   </td>
</tr>
<?php endif; ?>

i going report in bug tracker, wasn't sure actual build number was, since i'm using nightlies rather svn.

good catch & fix.

if case, why not add mobile img?

code: select all

$contact->params->def('icon_mobile', $pparams->get('icon_mobile'));
$image6 = jhtml::_('image.site', 'con_mobile.png','/images/m_images/', $contact->params->get('icon_mobile'),       '/images/m_images/', jtext::_('mobile').": ");
$contact->params->set('marker_mobile',$image6);


of course coresponding 'con_mobile' needed, & maybe other settings...